FAForever / fa

Lua code for FAF
228 stars 233 forks source link

Lacking feature parity for new patchnotes website #6483

Open lL1l1 opened 4 hours ago

lL1l1 commented 4 hours ago

Description of the Issue

The new patchnotes website has some missing features compared to the old one which make it worse to use. For example comparing https://faforever.github.io/fa/changelog/3810 and https://patchnotes.faforever.com/pages/balance/2024/3810.html:

Looking at https://patchnotes.faforever.com/:

Possible changes

Additional Context

The old patchnotes website repo is here: https://github.com/FAForever/patchnotes

Garanas commented 4 hours ago

Maybe unit icons could be grabbed from the generated github wiki, with unit ids or enhancement icon IDs as references in the snippet.

In my point of view, unit icons should be done in two steps:

We can add the source to the .gitignore file so that you can also have the files locally in your system for developing, without introducing hundreds of new files to the GitHub repository.

MrRowey commented 4 hours ago

was sad to see all the new improvements I made to patchnotes.faforever.com become obsolete.

MrRowey commented 4 hours ago

and to be honest, the way it was set up on the patchnote site is that it a lot of customer CSS to have the navigational stuff so I'm not sure if the doc site will be able to do as much as my customer changes do.