Evaluate the "sim-pause" feature introduced to prevent replays from desyncing

Basilisk3 commented 4 weeks ago

Describe the issue

When players leave the match, the game temporarily pauses the sim to prevent replays from desyncing. Essentially, this creates a stutter of varying severity every time someone leaves. While most of us are used to this being the case, I also think we can all agree that this is not an optimal solution:

It is difficult for newer players to understand why this is happening, especially since this feature is also not present on Steam.
It creates the impression of an unpolished experience.
There is a bug that prevents units from being selectable after the 'stutter.'

Things to investigate:

There is a UI mod which pauses the game while the different instances of the game catch up on data. I am not sure if this helps, but perhaps it is worth investigating.
How effective is this feature in the current release?
Does the feature also help with desyncs while playing?

Expected Behavior

No response

Screenshots

No response

lL1l1 commented 3 weeks ago

The UI mod in question is "pauseExit" in FAF vault by @4z0t

4z0t commented 3 weeks ago

Binary patches introduced delay input for certain amount of ticks during disconnection (10 iirc). We can adjust that to check how it will behave.

4z0t commented 3 weeks ago

https://github.com/FAForever/FA-Binary-Patches/blob/9e158406398a0d6c8cff952892bc2b542c8ac4b6/section/moho_decode.cpp#L519-L531

4z0t commented 3 weeks ago

There is also this one, but I dont know what it is for https://github.com/FAForever/FA-Binary-Patches/blob/9e158406398a0d6c8cff952892bc2b542c8ac4b6/section/moho_input.cpp#L19C1-L26C3

Basilisk3 commented 3 weeks ago

The UI mod in question is "pauseExit" in FAF vault by @4z0t

From my experience, this mod significantly improves the situation. Have you had a similar experience?

4z0t commented 3 weeks ago

I used it like 3 years ago, Didn't know it actually helps :D

Basilisk3 commented 3 weeks ago

It does feel better to me at least, it will be interesting to see what other people think 👍

4z0t commented 2 weeks ago

How are you going to test it?

FAForever / fa