search

FAForever / fa

Lua code for FAF
229 stars 234 forks source link

Remove Duplicate Lines in UEF ACU Upgrades #6501

Open MrRowey opened 3 weeks ago

MrRowey commented 3 weeks ago

Description

When updating enhancements scripts to the new format, it was noticed that the Tech 2 and Tech 3 upgrades have Duplicated Lines.

Course of Action

Remove the duplicated lines of code

Test Plan

Ensure that when removed the upgrade still functions the same

Learning Goals

Progress

No response

Garanas commented 3 weeks ago

@MrRowey you could improve this issue by referring the module (file) and the function (that you introduced, ha!). That way a new contributor does not have to search for what you're referring to - because if you take the issue on flat value right now then nobody would be able to decipher what it is that you're talking about unless they are already familiar with https://github.com/FAForever/fa/pull/6498 😄 !

MrRowey commented 2 weeks ago

ill update this tomorow