search

FAForever / faf-coop-maps

Coop maps for FAF
8 stars 21 forks source link

Aeon M2 - Fix bug with map not expanding if attackers killed quickly #412

Closed maudlin27 closed 1 year ago

maudlin27 commented 1 year ago

I had a game where the map wouldn't expand after the attackers were killed. Adding in logs to this revealed all the M3Attackers were returning true for :IsDead(). Adding in the code to force the next mission objective to run if all attackers are dead resolved the issue and meant the map expanded.

speed2CZ commented 1 year ago

How do you kill all the units so fast that the objective doesnt even start? Also what happens with the objective if it's assigned with units that are all dead?

maudlin27 commented 1 year ago

At the time there were lots of friendly forces near the edge of the map playable area so I'm guessing they managed to kill the units quickly. I can reproduce fairly easily offline (as my offline version reflects the separate pull request with the fix with the Cybran naval base detection, so I can just run a game with an AiX 3.0 at +10 gamespeed to quickly get to a similar position) but doubt I'll be able to using the online map (via the FAF client).

I've changed the pull request as doing testing on the later mission objectives after this I realised this objective must also be completed for the game to end - the revised approach should have the same effect of moving on to the next objective, and also marks this objective as complete (and so allows the mission complete message to appear)