search

FAForever / faf-java-api

The FAForever REST api
https://api.faforever.com
MIT License
30 stars 30 forks source link

Closes #820 Improve handling of failed steam redirect validations #822

Closed Ivan-Shaml closed 9 months ago

Ivan-Shaml commented 9 months ago

Closes #820 Note: I have implemented SteamService#handleInvalidOpenIdRedirect method, whit the mindset that the validation fails because an attacker tries to exploit the endpoint.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c293989) 78.84% compared to head (6d53333) 79.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #822 +/- ## ============================================= + Coverage 78.84% 79.00% +0.15% - Complexity 1263 1270 +7 ============================================= Files 243 243 Lines 3801 3815 +14 Branches 241 242 +1 ============================================= + Hits 2997 3014 +17 + Misses 698 695 -3 Partials 106 106 ``` | [Files](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...c/main/java/com/faforever/api/error/ErrorCode.java](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2FwaS9lcnJvci9FcnJvckNvZGUuamF2YQ==) | `99.15% <100.00%> (+<0.01%)` | :arrow_up: | | [...main/java/com/faforever/api/user/SteamService.java](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2FwaS91c2VyL1N0ZWFtU2VydmljZS5qYXZh) | `34.69% <93.75%> (+31.91%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [c293989...6d53333](https://app.codecov.io/gh/FAForever/faf-java-api/pull/822?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).