Closed Geosearchef closed 7 years ago
@IDragonfire https://github.com/FAForever/java-guidelines/wiki/Contribution-Guidelines#definition-of-done-dod
And please don't approve, since this allows the branch to be merged. Instead just make a "comment" review.
If you rebase on develop, the build error will be gone and I can merge it
done
approved means I looked over the code^^
@micheljung What is with unit tests?