FAForever / faf-java-server

Spring Boot based server for Forged Alliance Forever
12 stars 6 forks source link

Feature/#8 allow single connections only #19

Closed Geosearchef closed 7 years ago

IDragonfire commented 7 years ago

approved means I looked over the code^^

@micheljung What is with unit tests?

micheljung commented 7 years ago

@IDragonfire https://github.com/FAForever/java-guidelines/wiki/Contribution-Guidelines#definition-of-done-dod

And please don't approve, since this allows the branch to be merged. Instead just make a "comment" review.

micheljung commented 7 years ago

If you rebase on develop, the build error will be gone and I can merge it

Geosearchef commented 7 years ago

done