search

FAForever / faf-java-server

Spring Boot based server for Forged Alliance Forever
12 stars 6 forks source link

Feature/#7 provide player time zones #23

Closed Geosearchef closed 6 years ago

Geosearchef commented 7 years ago

There is no information in the current legacy protocol about timezones. I just added it as another field next to "country" in the player list (UserDetailsResponse).

Geosearchef commented 7 years ago

rebased, switches unit tests to Instant instead of timestamp

micheljung commented 7 years ago

Can you check why the tests fail?

Geosearchef commented 7 years ago

Done, some line slipped through rebasing multiple times.

Geosearchef commented 7 years ago

can this be merged?

micheljung commented 7 years ago

Not before travis builds successfully :) Maybe just need to rebase?

Geosearchef commented 7 years ago

Branch was/is rebased.

Is this just an error with travis itself? ERROR: Couldn't find env file: /home/travis/build/FAForever/faf-java-server/faf-stack/config/faf-legacy-apps/faf-legacy-apps.env

micheljung commented 7 years ago

Ah, faf-stack was changed, we need to execute this command before using docker-compose (in the .travisl.yml

cp -R config.template config
micheljung commented 6 years ago

Would you mind rebasing this so we can finish it up?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 84.57% when pulling 30d7326b5a9eda5dc8719985f68200c3328a12d1 on feature/#7-provide-player-time-zones into a1d683164d24c655a34cf096c035d93ea733bba4 on develop.