search

FAForever / faf-java-server

Spring Boot based server for Forged Alliance Forever
12 stars 6 forks source link

Feature/#30 increase map play count #36

Closed niklaskp closed 7 years ago

niklaskp commented 7 years ago

My approach on #30

I think this should work (tested manually using the unit-test dummy data, and unit tests with mocks), but I'm not really sure how to verify the mapping in a unit test. So any ideas welcome, on how to better test this.

Times played are currently counted per Map, not for the MapVersion. Is this correct?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.09%) to 84.329% when pulling 51b43275ffe6d14af6eb4b0768bb832e2dd030bc on NiklasKopp:feature/#30-increase-map-play-count into c875ccb568a6e0176c48e9be336bd5344033e581 on FAForever:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 84.537% when pulling ce052c3d47569352a9857cf5dcb3f759e6f7a34e on NiklasKopp:feature/#30-increase-map-play-count into 51b1ae0a61ef0d77a547ce602f68d17dc253cb77 on FAForever:develop.

micheljung commented 7 years ago

Muchas gracias!

I'll squash and merge it.