FAForever / faf-league-service

The league service of Forged Alliance Forever
GNU General Public License v3.0
0 stars 0 forks source link

Replace Travis with github actions #25

Closed BlackYps closed 2 years ago

BlackYps commented 3 years ago

Closes #17

Bear with me, because I don't really know what I am doing. I tried to use the file from the server repo and make the necessary changes for this repo. I don't really know if it worked.

BlackYps commented 2 years ago

bootstrap_database.sh doesn't finish. I don't really understand why, because I didn't make any meaningful changes to it and obviously it worked while it was used by travis. Does anyone have a good idea?

Askaholic commented 2 years ago

Hmm I’m not sure either. I would set the database container up as a service though like the rabbitmq one. That’s also how we do it in other repos like the lobby server and java api.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@60fe3bf). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #25   +/-   ##
==========================================
  Coverage           ?   95.55%           
==========================================
  Files              ?       11           
  Lines              ?      405           
  Branches           ?        0           
==========================================
  Hits               ?      387           
  Misses             ?       18           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60fe3bf...15f7fb7. Read the comment docs.

BlackYps commented 2 years ago

Seems like I got it