search

FAForever / faf-league-service

The league service of Forged Alliance Forever
GNU General Public License v3.0
0 stars 0 forks source link

Make number of placement games configurable by season #32

Closed BlackYps closed 3 years ago

BlackYps commented 3 years ago

Closes #30

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (5662d3f) into develop (963ccd4) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #32      +/-   ##
===========================================
+ Coverage    95.55%   95.56%   +0.01%     
===========================================
  Files           11       11              
  Lines          405      406       +1     
===========================================
+ Hits           387      388       +1     
  Misses          18       18
Impacted Files Coverage Δ
service/config.py 100.00% <ø> (ø)
service/db/models.py 100.00% <ø> (ø)
service/league_service/league_rater.py 96.87% <ø> (ø)
service/league_service/league_service.py 90.24% <100.00%> (+0.07%) :arrow_up:
service/league_service/typedefs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 963ccd4...5662d3f. Read the comment docs.

BlackYps commented 3 years ago

We already have a test for the placements. I think testing the db interaction is a bit overkill.