Closed BlackYps closed 2 years ago
Merging #45 (57c1b22) into develop (487a631) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #45 +/- ##
========================================
Coverage 95.60% 95.60%
========================================
Files 11 11
Lines 410 410
========================================
Hits 392 392
Misses 18 18
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 487a631...57c1b22. Read the comment docs.
With this are the name keys still going to have the .# at the end of them or will that be removed?
They will still have the number at the end. This makes every name key unique. Now that I think about it I am not sure if it is necessary to have unique name keys...
Yes because it is this fact that would cause the name key bloat in the client i18n file. If every season just wants to be translated as {descriptor} season {#} then they really only need a key for the descriptor. Which reduces the number of variables we need and makes it easier so that every season release doesn't need a client release
During review of the client ui code we noticed that having the number of the season explicitly stored makes internationalization a lot easier.
The placement games column was added earlier, but hadn't added it to the test data yet.