search

FAForever / faf-league-service

The league service of Forged Alliance Forever
GNU General Public License v3.0
0 stars 0 forks source link

Remove exclusive queue and and use exclusive consumer #46

Closed Sheikah45 closed 2 years ago

Sheikah45 commented 2 years ago

The durable and exclusive flags on the queue are mutually exclusive, this prevents us from creating a durable queue which preserves messages during service restart.

The solution is to use a durable queue and an exclusive consumer this will force the queue to be durable but also allow only one consumer on the queue at a time

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (54581a1) into develop (f783a82) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 54581a1 differs from pull request most recent head dc2e7e3. Consider uploading reports for the commit dc2e7e3 to get more accurate results Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #46   +/-   ##
========================================
  Coverage    95.60%   95.60%           
========================================
  Files           11       11           
  Lines          410      410           
========================================
  Hits           392      392           
  Misses          18       18
Impacted Files Coverage Δ
service/message_queue_service.py 97.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f783a82...dc2e7e3. Read the comment docs.

Sheikah45 commented 2 years ago

Alright should be good to go now