FAForever / faf-league-service

The league service of Forged Alliance Forever
GNU General Public License v3.0
0 stars 0 forks source link

Handle season generation in python instead of sql #60

Closed BlackYps closed 1 year ago

BlackYps commented 1 year ago

Closes #58

We can now set the season duration from the config

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.33 :tada:

Comparison is base (8d7a6d2) 96.04% compared to head (b828ded) 96.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #60 +/- ## =========================================== + Coverage 96.04% 96.37% +0.33% =========================================== Files 12 12 Lines 455 497 +42 =========================================== + Hits 437 479 +42 Misses 18 18 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/faf-league-service/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [service/db/models.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9kYi9tb2RlbHMucHk=) | `100.00% <ø> (ø)` | | | [service/config.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9jb25maWcucHk=) | `100.00% <100.00%> (ø)` | | | [service/season\_generator.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9zZWFzb25fZ2VuZXJhdG9yLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

BlackYps commented 1 year ago

Thank you for your review!