FAForever / faf-league-service

The league service of Forged Alliance Forever
GNU General Public License v3.0
0 stars 0 forks source link

Add Game id column to journal #66

Closed BlackYps closed 1 year ago

BlackYps commented 1 year ago

This depends on https://github.com/FAForever/server/pull/973 We persist the game id in the database so the client can later look up the correct divisions for a replay.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (f91bd5f) 96.37% compared to head (02180d7) 96.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #66 +/- ## =========================================== + Coverage 96.37% 96.39% +0.01% =========================================== Files 12 12 Lines 497 499 +2 =========================================== + Hits 479 481 +2 Misses 18 18 ``` | [Files Changed](https://app.codecov.io/gh/FAForever/faf-league-service/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [service/db/models.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9kYi9tb2RlbHMucHk=) | `100.00% <ø> (ø)` | | | [service/league\_service/league\_service.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9sZWFndWVfc2VydmljZS9sZWFndWVfc2VydmljZS5weQ==) | `91.17% <100.00%> (ø)` | | | [service/league\_service/typedefs.py](https://app.codecov.io/gh/FAForever/faf-league-service/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c2VydmljZS9sZWFndWVfc2VydmljZS90eXBlZGVmcy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.