feature: Migrate to Java 17 #129

FAForever / faf-moderator-client

FAF Moderator Client

MIT License

4 stars 12 forks source link

feature: Migrate to Java 17 #129 #139

Closed basalt79 closed 3 years ago

basalt79 commented 3 years ago

i left out the .idea folder changes on purpose would be great to get also the hacktoberfest-accepted label Closes #129

Sheikah45 commented 3 years ago

Unfortunately just changing the source compatibility label is not enough to migrate to java 17. Likely some of the dependencies also have to be updated to enable full support on java 17. And while updating the dependencies they may introduce depreciations of breaking changes that need to be accounted for.

Additionally java16 changed how some modules are exported and accessed via the class path so those modules need to be changed to allow compilation and execution with a java17 jre as well.

Brutus5000 commented 3 years ago

Well I just tested it and suprisingly it works where it shouldn't.