FAForever / faf-moderator-client

FAF Moderator Client
MIT License
4 stars 12 forks source link

Update method showModeratorEvent to use playerNameFromCommandSource instead of sender #212

Closed magge-faf closed 4 months ago

magge-faf commented 4 months ago

Improved the moderation workflow by having concise one-liners, instead of detailed event dumps. Additional info will be refactored later.

The output-decision was voted in Zulip by the Moderators, how we should introduce that basic feature.

Preferred:

Screenshot ![image](https://github.com/FAForever/faf-moderator-client/assets/101107758/5f5853d0-0e40-485c-8da8-f5843e0316c4)

instead:

Screenshot ![image](https://github.com/FAForever/faf-moderator-client/assets/101107758/367d1c06-9f73-4254-8c63-329c09e69373)

Outline:

Info:

sender was replaced with playerNameFromCommandSource or playerNameFromArmy in that commit

Both represent the player name, I went with playerNameFromCommandSource, because it should be more resistant against manipulation.

Fixes #205

magge-faf commented 4 months ago

I am unable to add Reviewers (top right in GitHub, gear-wheel is missing next to Reviewers). I think it is permission related? Well, I go with tagging again:

Thank you for reviewing @Brutus5000, @Sheikah45

Could you release an officially Mordor version with all the recent changes to make those features accessible for every Moderator, please?