search

FAForever / ice-adapter

Deprecated C++ ICE adapter - please use java-ice-adapter instead!
https://github.com/FAForever/java-ice-adapter
GNU General Public License v3.0
11 stars 10 forks source link

ConnectivityDialog needs theming #39

Closed muellni closed 7 years ago

muellni commented 7 years ago

The QTableWidget vertical and horizontal headers need to be styled. Using QHeaderView::section { background-color: green; } in client.css didn't work.

Wesmania commented 7 years ago

A widget needs to have a parent set to use parent's theming. From what I can see you use loadUi to make the widget, and I guess it doesn't set any parents. I'd suggest making a separate class for the dialog (as UI) that uses loadUiType, moving all the UI stuff there, then creating and operating on this in place of loadUi (passing it client as parent).

muellni commented 7 years ago

setting the dialogs parent was the thing which I implemented today, so the ConnectivityDialog is now themed. Only things missing is the vertical and horizontal headers of the QTableWidget I use

muellni commented 7 years ago

https://github.com/FAForever/client/blob/feature/ice-adapter/src/connectivity/ConnectivityDialog.py#L24

muellni commented 7 years ago

solved by https://github.com/FAForever/client/blob/feature/ice-adapter/src/connectivity/ConnectivityDialog.py#L28

muellni commented 7 years ago

The vertical header still needs theming

muellni commented 7 years ago

fixed now I hope

muellni commented 7 years ago

now the second table entry still has a wrong background color

muellni commented 7 years ago

should be fixed ... again: https://github.com/FAForever/client/blob/feature/ice-adapter/res/client/client.css#L237