search

FAForever / ice-adapter

Deprecated C++ ICE adapter - please use java-ice-adapter instead!
https://github.com/FAForever/java-ice-adapter
GNU General Public License v3.0
11 stars 10 forks source link

handle Alt+F4 for graceful disconnect #50

Closed muellni closed 6 years ago

muellni commented 7 years ago

Current situation is that Alt-F4-quitting the game is connection lost for the other players. Maybe ice-adapter could send a disconnect packet to the other peers upon closed game.

b2ag commented 7 years ago

This would also be an improvement for other players when someones game crashes. Maybe only after crashed player closes the stack trace dialog, but definitely an overall improvement.

muellni commented 7 years ago

The ice-adapter could only detect a closed game by a TCP disconnect in the GPGNet-connection.

muellni commented 6 years ago

Neither EjectPeer nor DisconnectFromPeer prevent the peer from timing out. I guess there's no way to make the peer being disconnected without timing out.