FAForever / ice-adapter

Deprecated C++ ICE adapter - please use java-ice-adapter instead!
https://github.com/FAForever/java-ice-adapter
GNU General Public License v3.0
11 stars 10 forks source link

Investigate server additional ConnectToPeer call #55

Closed muellni closed 6 years ago

muellni commented 6 years ago

It looks like the server is doing an unnecessary call to ConnectToPeer here: https://github.com/muellni/server/blob/feature/233-271-237-ICE/server/gameconnection.py#L167

Sheeo commented 6 years ago

No, that's necessary--joinGame does not actually establish a peer connection, so you need to send this in succession after that.

Notice the connection to the host is indeed only established once: https://github.com/muellni/server/blob/feature/233-271-237-ICE/server/gameconnection.py#L136.