search

FAForever / java-ice-adapter

A P2P connection proxy for Supreme Commander: Forged Alliance using ICE
MIT License
5 stars 12 forks source link

Use PicoCLI over custom args parsing #36

Closed Brutus5000 closed 2 years ago

Brutus5000 commented 2 years ago

Due to the fact that the cli launch process is decoupled from start function, it is now also possible to start the ICE adapter from inside another Java process.

(I didn't test it, maybe JavaFX fails if to main windows are launched)

Brutus5000 commented 2 years ago

I wouldn't recommend launching it from inside anything else yet due to the usage of System.exit in many places

Sheikah45 commented 2 years ago

Yeah just tested it, picocli doesn't work through inheritance. So either need to make the iceOptions a filed with the @ ArgGroup annotation or put the annotations directly in CLILauncher