search

FAForever / java-ice-adapter

A P2P connection proxy for Supreme Commander: Forged Alliance using ICE
MIT License
5 stars 12 forks source link

Infer static code analysis #49

Closed rigomate closed 1 week ago

rigomate commented 1 year ago

Add infer static code analysis checker to builds. Solve one trivial possible null pointer dereferencing.

rigomate commented 1 year ago

The infer action gives such an overview of the issues, which it suspects: image

Brutus5000 commented 1 year ago

If we run it in the CI where do we see the results? Your screenshot indicates it's somewhere on Github?

Sheikah45 commented 1 year ago

Also how is this different from codacy which we use in other repositories

rigomate commented 1 year ago

It can be seen in the actions section at github: In my fork it is here: https://github.com/rigomate/java-ice-adapter/actions/runs/6855882675

I don't know how it differs codacy, but my philosophy is simple: use as many code checkers as possible. Maybe the will find some viable issue. I think this null pointer call which it found and is fixed in the pull request sets a good example, that this tool might find real issues.

Cheers!