search

FAForever / kotlin-ice-adapter

MIT License
2 stars 3 forks source link

Make allowHost, allowReflexive and allowRelay configurable #7

Closed BlackYps closed 1 year ago

BlackYps commented 1 year ago

closes #3

I didn't know what to put into the parameter desctriptions. Also I don't know if localPlayerId was supposed to be refactored in this way, but it made sense to me.

Brutus5000 commented 1 year ago

To answer your question: I'm not so super happy with passing the iceOptions around everywhere, but until the core functionality is all working, there isn't much point in not doing it as long as we don't really know what is needed where. Maybe it makes sense to split the interface into sub-interfaces later on.

BlackYps commented 1 year ago

what interface and subinterfaces are you talking about?

Brutus5000 commented 1 year ago

I was talking about IceOptions, but i see it's a data class. I was thinking of interface from the other Quarkus projects :D So the IceOptions data class could implement multiple interfaces that just show a "view" to some codependent variables. But that is not relevant right now.