search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Issue/#970 Prevent queue pop timer from becoming negative #1014

Closed Askaholic closed 4 months ago

Askaholic commented 4 months ago

This adds a quick fix to prevent the timer from going negative by adding a minimum pop time to the config as well. Ideally the queue rate calculation should be fixed as well in a separate PR.

Closes #970

BlackYps commented 4 months ago

Is five seconds enough to allow recovery of the timer or will it stay stuck on the five seconds?

Askaholic commented 4 months ago

Good question. I think it depends on how many players are in the queue. If the number of players in the queue stays the same or increases then the timer will continue to be stuck at the minimum. I’m not sure what that number has to be though.

BlackYps commented 4 months ago

15 seconds sounds like a reasonable minimum to me, even if it stays stuck at this for some time. 5 seconds is very low

Askaholic commented 4 months ago

Fine with me