search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Send ratings of search parties in queue #1020

Open BlackYps opened 2 months ago

BlackYps commented 2 months ago

Sends the ratings of search parties in a queue. This is a step to bring back the indicator that the python client had, but this time extended for all matchmaker queues. We send just the rating, so the client can decide on its own how big of a range it wants to allow to display the indicator as a successful match also depends on the deviation of the player seeing the notification

BlackYps commented 2 months ago

I'm not sure why I broke a seemingly unrelated test

BlackYps commented 6 days ago

I just realized something: The 1v1 rating gets adjusted for new players. So the client needs to know how this adjustment works, so it can calculate the adjusted rating of the logged in player to determine if that player is actually close to the active rating ranges. We can implement the formula to adjust the rating in the client, but the formula depends on server config settings that can change. If we hardcode them in the client, the calculations might be off. So what can we do about this? I think the safest way would be if the server sends the adjusted rating to the client. Then the client doesn't even need to know about the adjustment calculations.

Askaholic commented 6 days ago

I agree, we should be sending whatever number the matchmaker is actually using if possible.

BlackYps commented 4 days ago

I opened a new issue to discuss this. https://github.com/FAForever/server/issues/1024 We should make the required changes in a separate pull request and then revisit this one once that is merged.