search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 62 forks source link

Broken rating #30

Closed JeroenDeDauw closed 9 years ago

JeroenDeDauw commented 9 years ago

Either this stuff fatals or my IDE is being fail.

https://github.com/FAForever/server/blob/develop/src/gameconnection.py#L836-L845

refs

Sheeo commented 9 years ago

It will. It's being reworked on the refactor/rating branch.

The previously included trueskill code was broken when moving to python 3, and I've chosen not to try and port it, relying instead on this library.

JeroenDeDauw commented 9 years ago

What's the plan with this refactor/rating branch? And why is this stuff happening on a diverging branch anyway? Somewhat annoying to deal with no?

Sheeo commented 9 years ago

It is to seperate the state of work on the networking side from work on getting the rating working again.

Branching and merging/rebasing with git is bliss and not a problem.