Open Askaholic opened 4 years ago
It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.
We could go with a "polymorphic" approach:
{ "command": "party", "action": "invite", "recipient_id": <player_id> }
Or more of a "compositional" approach:
{ "command": "party", "action": "invite", "data": { "recipient_id": <player_id> } }
The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.
I would vote for the polymorphic as all the other commands follow this format. And it would be weird to start mixing them up now.
It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.
We could go with a "polymorphic" approach:
Or more of a "compositional" approach:
The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.