search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Restrict who can send invites #692

Open Askaholic opened 3 years ago

Askaholic commented 3 years ago

We probably need some way of limiting who can send you invites to avoid streamers being spammed with invites. Maybe limit invites to friends only, or maybe a way to disable them altogether (so that you would be the one sending the invites).

eoinnoble commented 3 years ago

Open (default) / friends only / closed, maybe? What would be the desired experience for the person sending the invite, would they need to be told 'X only accepts invites from friends' or would the invitation fail silently?

Askaholic commented 3 years ago

So far I haven't seen or heard any complaints about this being an issue, so maybe it's not worth spending time to implement this. We already reject invites from foes so if a particular user starts spamming you with invites you can always foe them.

The real question here is if we add some setting for this, where does that setting get saved? In the database so the client can set it once and it stays forever? In memory so the client has to send a message on every login to update the setting? It would also be possible to implement something like this entirely on the client side in which case the setting can be saved in the client preferences. The only thing about a client implementation is the invites would have to fail silently. They wouldn't actually fail from the servers perspective, the user would just ignore them.

eoinnoble commented 3 years ago

I think failing the invites silently sounds sensible, maybe with some kind of default messaging in the invite window, "Your friend not receiving the invite? Ask them to check their invitation preferences."

KaukaHan commented 2 years ago

in my opinion only allowing friends to invite seems good enough. why should i invite a stranger or he accept my invite ? if my "friend" hasnt friended me, a msg indicating this would be usefull, so i can tell him in chat to friend me. its just a one time action for a handfull of players.

Eternal-ll commented 1 year ago

It is better to make blacklist who cant send you invites, like a button on invite so you can stop it. People must have ability to invite non-friend players, because teammate is not always a friend and it is a bit complicated schema for simple invite (add to friend > send invite)