search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 61 forks source link

FAF client is issuing wrongful connection violations for issues in connection that it itself caused #908

Closed tatsujb closed 2 years ago

tatsujb commented 2 years ago

this is the second time this has happened to me. FA fails to connect with the other player and then when it finally closes back on FAF there's a popup waiting for me saying i've been issued a violation.

how is that fair?

also this is darn pattern

Sheikah45 commented 2 years ago

Why are you claiming the client caused the connection issue? If you can't connect to the host that is an issue with your connection and the system is operating as intended

tatsujb commented 2 years ago

the UX of this is that the user has no head's up that the server is messing up and then gets punished for it. it's utterly stupid. fix the connection issues instead.

tatsujb commented 2 years ago

If you can't connect to the host that is an issue with your connection

there is no problem with my connection.

Why are you claiming the client caused the connection issue

i'm on the server's issue reporting

Sheikah45 commented 2 years ago

the UX of this is that the user has no head's up that the server is messing up and then gets punished for it. it's utterly stupid. fix the connection issues instead.

The server is not messing up the connection in any way. It is just observing if you are connected to the host as it is all peer to peer. I am not sure why you think the server is messing up the connection?

The only thing the server has is a timeout where if you don't connect in 3 minutes it calls it failed as otherwise people would sit there forever which is reasonable.

tatsujb commented 2 years ago

because it's nothing on my end

sometimes it even starts a game and has me sitting on waiting for the other player while the other is able to type and is waiting for me. why?

Sheikah45 commented 2 years ago

because it's nothing on my end

sometimes it even starts a game and has me sitting on waiting for the other player while the other is able to type and is waiting for me. why?

Just because the game launched that does not mean you are connected. I think you are confusing being connected to IRC with being connected with the player.

If the game doesn't launch that means your p2p connection to the host failed. If you can't connect to the host you have a bad connection and are given a violation.

Since the game is p2p you can have a bad connection to a player even if your internet is "good"

Sheikah45 commented 2 years ago

because it's nothing on my end

sometimes it even starts a game and has me sitting on waiting for the other player while the other is able to type and is waiting for me. why?

If you can't connect then it is something on your end definitely. In a 1-to-1 connection you just can't connect to each other.

Askaholic commented 2 years ago

The lobby server can't cause your game to fail to connect. If you're not connecting it's an issue between your network, ICE and the other player's network. All the lobby server can do is observe the fact that you didn't connect to the host and issue a violation. There will be some false positives which is why we don't issue any penalty until the second violation. If this happens too often and we need to up the number of unpenalized violations we can discuss that separately, but I don't see an actual server bug described here so I'm closing this issue.

tatsujb commented 2 years ago

well all I've gotten is false positives as I'd define them. there's no way this is my fault.

BlackYps commented 2 years ago

How do you know that it is not your fault? Having a generally stable internet connection is not a sufficient criterion to judge this. You connect peer to peer to a random person anywhere in the world, it is possible that bad routing or a shitty ISP makes a connection fail sometimes.

Are we talking about 1v1 or team games here btw?

tatsujb commented 1 year ago

Just happened twice again.

Definitely not my fault because FAF is even issuing out confusing messaging : Screenshot from 2023-01-20 02-02-26 Screenshot from 2023-01-20 02-02-32 I get both these error messages one on top of the other (like I have to dismiss the first and then I have to dismiss the second one that's behind it, you can even see that the background greying out stacked) and they both contradict each other.

this can't be the intended behavior.

I have two normal games then two that start up but automatically close and fall back to faf

Steps to reproduce : click this button image

do nothing else that's literally it.

it's not even consistent I get way more matching that works than matching that doesn't and the ones that don't are entirely random. nothing sticks out.

this is on FAF's end

tatsujb commented 1 year ago

it just keeps happening every time it's more wrong than the last

this time FA sais the two players are using a different client version. this is not my fault. I'm using 2023.1.2 that's the current correct version.

the people using the many different pre-releases are the ones in the wrong and shouldn't be queuing up for ladder. I shoulnd't be getting the warning nor the 10 min matchmaking ban.

please lift my matchmaking ban

BlackYps commented 1 year ago

What we could do is not giving out violations for 1v1 matchmaking. The host is assigned randomly and if the connection fails the person that is not the host will get issued a violation. But with only a single connection it is impossible to tell who of the two ends is to blame.

Askaholic commented 1 year ago

@tatsujb I understand that you are frustrated but that is completely untrue and you know that. Please keep GitHub discussions civil and on topic.