search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Coop leaderboards are broken: sim modded games counts #913

Closed K-ETFreeman closed 1 year ago

K-ETFreeman commented 2 years ago

Just check out the # 1 replay of 5th mission (Mind Games, 23m 40s by pobus) You'll see this: image

This guy obvsiously have sim mod (resourses x1000000 or something like that) So leadebord has no meaning because of this bug, need to fix & clear leaderboard from modded replays somehow

Askaholic commented 2 years ago

Can you please post the replay id

K-ETFreeman commented 2 years ago

Can you please post the replay id

Not sure if i can (yesterday was banned for smurfing, for a week) Can give you replay file temp.coop.zip

It has "uid": 15440072 . But may be this is user id, not the replay id? edited: this is replay id, [link is working](https://replay.faforever.com/15440072)

Askaholic commented 2 years ago

Thanks, yea that’s the replay id

Marc-Spector commented 2 years ago

It is server issue that handles game results.

K-ETFreeman commented 2 years ago

Now meltdown (4th mission) is taken by the cheater too (Abrissgurke) and 1st and 2nd places in Mind games (5th mission) is taken by the cheaters need to do something :C they not using sim mods, probably cheat engine or smth like that (i tried play with sim mod - game didnt appear in leaderboard)

Can someone delete cheater replays sometimes at least?

UPD: i beat the cheater on meltdown, but still - in a year leaderboard gonna contain cheater replays only, what's the point of it then

Brutus5000 commented 2 years ago

Note: We need a new bantype coop

K-ETFreeman commented 2 years ago

Meltdown mission is now taken by cheater too (the guy with nickname "momoception") replay id is 17992592

not only that mission, red flag and down missions too

Askaholic commented 1 year ago

So I just took a look at the replay file and there are no sim mods being used. I also checked the server code and it should be invalidating any games that are using sim mods. So my guess is that this player is using some sort of exploit in game. That's unfortunately nothing we can detect on the server side so I'm gonna have to close this issue. Maybe @Garanas wants to take a look at the replays though in case there's a game bug that can be fixed.

Garanas commented 1 year ago

I'm fairly certain that this was related to:

And that is fixed now.