search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 61 forks source link

Replay looks missing at search while local replay file looks consistent #933

Open marvin4ward opened 2 years ago

marvin4ward commented 2 years ago

Describe the bug A game was played but result or record about the match is missing at tab of replay search https://replay.faforever.com/18553425 is 404 Original local copy of the match 18553425-derKoMaNder.zip

To Reproduce Play dozen of games and check that one of them isnot in the DB

Expected behavior Replay ID should be searchable

Screenshots Replay file is attached Additional context The game has no desync or unexpected mutual disconects.

marvin4ward commented 2 years ago

another case: https://replay.faforever.com/18576489 Probably some one did not left the game for a long time after the match was over, and that let FAF system miss replay out of attention.

marvin4ward commented 2 years ago

https://replay.faforever.com/18603159 another case. Hope that should be enough to find out root cause of the issue. Please close the issue, if that is just normal behave

Brutus5000 commented 2 years ago

@Askaholic I browsed through the logs. For the last 2 games I found this in the logs:

INFO Nov 22 17:08:55 CustomGame.18576489 Game cancelled pre launch INFO Nov 26 12:40:01 CustomGame.18603159 Game cancelled pre launch

Thus there is no row persisted in the game_stats table.

Sheikah45 commented 2 years ago

It looks like there are quite a few CustomGames that got cancelled. I thought cancelling was only for ladder games?

marvin4ward commented 2 years ago

Why it got canceled? Who or what initiate game cancelation?

Askaholic commented 2 years ago

Any game can be cancelled by the host sending a GameState: Ended command before the game has launched. This is only supposed to happen when you close Forged Alliance.

marvin4ward commented 2 years ago

But if the game was started and finished in 30-40 minutes, Why it could be Ended before? Can we find that message in local logs?

Askaholic commented 2 years ago

It’s a GPGnet message, I’m not sure if it gets logged. It has a bit of a misleading name, what it really means is that ForgedAlliance was closed.