FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Incorrect exception logging call #937

Closed Askaholic closed 1 year ago

Askaholic commented 1 year ago

Logging call still needs a message:

ERROR    Dec 18  22:18:13 asyncio                        Task exception was never retrieved
future: <Task finished name='Task-41509' coro=<ServerContext.client_connected() done, defined at /code/server/servercontext.py:112> exception=TypeError("exception() missing 1 required positional argument: 'msg'")>
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/asyncio/streams.py", line 540, in readline
    line = await self.readuntil(sep)
  File "/usr/local/lib/python3.9/asyncio/streams.py", line 635, in readuntil
    raise exceptions.LimitOverrunError(
asyncio.exceptions.LimitOverrunError: Separator is found, but chunk is longer than limit
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/code/server/servercontext.py", line 125, in client_connected
    message = await protocol.read_message()
  File "/code/server/protocol/simple_json.py", line 12, in read_message
    line = await self.reader.readline()
  File "/usr/local/lib/python3.9/asyncio/streams.py", line 549, in readline
    raise ValueError(e.args[0])
ValueError: Separator is found, but chunk is longer than limit
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/code/server/servercontext.py", line 136, in client_connected
    self._logger.exception()
TypeError: exception() missing 1 required positional argument: 'msg'