FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
67 stars 62 forks source link

Unrank games that are mutual draw #948

Open BlackYps opened 1 year ago

BlackYps commented 1 year ago

related to #936 Players perceive the button for a draw in the diplomacy menu as "let's pretend this game never happened" and it's primarily used when people don't like the map or there are technical problems like a player losing connection early on. Consequently, we should reintroduce the mutual draw logic that was removed in #940 and fix the issue that everyone had to send MUTUAL_DRAW to unrank, as dropped out players obviously can't send that.

Sheikah45 commented 1 year ago

Do you let people do a mutual draw after someone has died normally? And should this unrank the game?

In other places we have code to explicitly rank after the first acu death so those two seem at odds. And there isn't a way right now for the game to differentiate between dc and normal death

BlackYps commented 1 year ago

I imagine if the acu death was legit then the winning team wouldn't agree to the draw

Sheikah45 commented 1 year ago

I guess so. But to me it has just always felt like an opportunity for rating manipulation so you can choose your maps or opponents in the matchmaker. So that is why I am uncertain it is necessary

BlackYps commented 1 year ago

Then it's probably good to discuss this on the forum. Form discord i gathered that many people have a different opinion, but we didn't discuss the reasons in detail

Brutus5000 commented 1 year ago

I got offered a lot of draws in 1v1 because players didn't like to play a 20x20 map. When I refused they just left anyway.

BlackYps commented 1 year ago

In the light of the connection problems it was suggested again that a diplomacy draw should unrank the game. I think this is a good idea as there is no other way to abort a game where somebody disconnected and the diplomacy menu requires both teams to consent, so I don't see an opportunity for rating manipulation.

BlackYps commented 1 year ago

Is anyone strongly opposed to this solution?