search

FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 61 forks source link

Fix docker build #955

Closed Askaholic closed 1 year ago

Askaholic commented 1 year ago

Seems like some change in setuptools broke our docker build, however, this really just exposed a bug in our build where the .git directory was not being copied to the docker context and therefore the git version tag couldn't be found from the setup.py file. I went ahead and rewrote the dockerfile to use a multi-stage approach so we should no longer have build tools like git and pipenv installed in the final container.

Closes #953

Askaholic commented 1 year ago

I don’t think so. The python files are just installed to the system anyway. The user isn’t needed at all during the build process, it just exists for the container to use at run time.

Brutus5000 commented 1 year ago

So "other" users have read/execute permissions on the code directory?

Askaholic commented 1 year ago

Yes, the code is installed as a python package with pip. Just like if you were to system install any other dependency with pip.

Askaholic commented 1 year ago

Tested on the test server and it still works with the existing configuration.