FAForever / server

The servercode for the Forged Alliance Forever lobby
http://www.faforever.com
GNU General Public License v3.0
66 stars 61 forks source link

Server no longer uses `SINGLE_PLAYER` validity state #993

Closed Askaholic closed 11 months ago

Askaholic commented 11 months ago

The last game with a SINGLE_PLAYER validity that I can see in the test database is from July 2, 2020. At some point around that time a code change was deployed where UNEVEN_TEAMS_NOT_RANKED began taking precedence over SINGLE_PLAYER causing all single player games to be marked as 'uneven teams' instead.

It looks like it might have happened in #388.

We should probably swap the order of the checks so that SINGLE_PLAYER takes priority.