FAForever / website

FAForever's Website
http://www.faforever.com
MIT License
21 stars 37 forks source link

Clan update and create message validations #531

Closed beckpaul closed 11 months ago

beckpaul commented 11 months ago

Edit error messages for clan creation/updating to address #528

We may not need the error regarding an empty descriptions as:

title='description',
required='required',

Handles empty for us natively but there no harm in maintaining both errors.

Also included

Before:
Screenshot 2023-12-14 at 15 49 09
After: Screenshot 2023-12-14 at 15 49 50

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f8d01b) 41.17% compared to head (6e67c32) 41.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #531 +/- ## ======================================== Coverage 41.17% 41.17% ======================================== Files 71 71 Lines 1734 1734 Branches 210 210 ======================================== Hits 714 714 Misses 988 988 Partials 32 32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fcaps commented 11 months ago

@beckpaul if you add: closes #528

merging the pr will automatically close the issue.