search

FAForever / website

FAForever's Website
http://www.faforever.com
MIT License
21 stars 37 forks source link

Increase pill roundness and horizontal padding #536

Closed pumbas600 closed 10 months ago

pumbas600 commented 10 months ago

Hi :wave:

I noticed that the pill buttons on the website in a lot of cases weren't quite rounded enough to be a full pill button.

I also increased the horizontal padding on the buttons which I think improves their shape slightly.

Before After
Before Card After Card
Before Landing After Landing
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8daa828) 41.17% compared to head (d3df235) 41.17%. Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #536 +/- ## ======================================== Coverage 41.17% 41.17% ======================================== Files 71 71 Lines 1734 1734 Branches 210 210 ======================================== Hits 714 714 Misses 988 988 Partials 32 32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fcaps commented 10 months ago

Hi @pumbas600, and thx for your PR!

There is css "trick" for doing it without the 9999px border-radius: 25%/50% looks quite similar, you think there are drawbacks? Other changes looking good to be merged.