when importing fsdb ignore stop_time unless task_state="STOPPED"

[kuaka]

importing forbes 2018 fsdb into a clean database then deleting the 'fake' tracks and uploading the real igc files results in no pilot reaching goal. However in the official scores several pilots are in goal.

Looking at the airscore track maps I can see pilots making goal but they are not considered in goal:

wondering if there is a problem with the imported task deadlines or something, although the time on the track points near goal are well within the deadline in task settings.

[kuaka]

This also causes scoring to fail as difficulty calculation errors with index out of range. So there are tracks that have flown further than the max landout distance. Which is inconsistent. These could be those that should have made goal.

[biuti]

I can see that a stopped time was imported:

Probably with all tasks. The xml file has a stop_time in every task, should be "". Try deleting stopped time in settings and let me know. I will also change the timings page so that if multi start and / or stopped time are set, panels are open.

[kuaka]

ok thanks. good spotting. I have raised a question here: https://github.com/FlareTiming/2018-forbes-flatlands-score/issues/3 It may be a flaretiming issue or an airscore issue, depending on what the fsdb "standard" is.

[kuaka]

removing the stopped time and doing a full re-score fixes the problem. I will not close issue until we hear the outcome of the issue on FlareTiming

[philderbeast]

I ignore the stopped time unless it is a stopped task. I'm not sure that's the right thing to do.

[kuaka]

I looked at the 2019 Italian open file this also is of the same format (stop_time present for every task). Therefore airScore should use the same logic as Flare Timing and only consider the stop_time if task_state="STOPPED"

[kuaka]

fixed with https://github.com/FAI-CIVL/FAI-Airscore/commit/8fad6a6592b91c56c82b2000b6d24171120fb37f tested with forbes 2018 fsdb