search

FAI-CIVL / FAI-Airscore

AirScore - online paragliding / hanggliding GAP-based scoring software.
https://airscore.cc/
GNU General Public License v3.0
13 stars 17 forks source link

any more case changes in the DB? #209

Open kuaka opened 3 years ago

kuaka commented 3 years ago

Are there any more case changes happening in the DB such as elapsed time - > ELAPSED TIME? we need to be sure that what comes out of the DB is exactly what goes in otherwise we are just creating complexity and potential bugs.

biuti commented 3 years ago

we have comp_type that is stored also in main table as uppercase. At the moment I think we are not even using it, but we could decide to store lowercase just to be consistent with everything else. I think we also have some columns we could delete: Participant.parClass ForComp.forPk

I'll check views as well if there are other case changes but I don't think so.

biuti commented 3 years ago

So I had a look, apart from the two columns above, there is: ForComp.formula_type ForComp.formula.version This could easily become formula properties for from formula_name ForComp.external_name Probably not needed if we check that a formula exists when we convert external event

We should also add a table (probably two) for more participants attribute to use for classifications. Would do those changes in different steps. First two are fairly easy and I will commit today. I will test formula changes in a different branch and then commit when ok. Changing from attributes to properties shouldn't be difficult tho. The new tables and classifications logic has to be thought a bit more.

I also saw that in Airscore.sql we create tables to delete and replace them with views. Is there a reason for that or could we simplify the procedure?

kuaka commented 3 years ago

please realize that issues are one topic discussions for reasons we have already covered a few times. I have moved your last question to #217 the other discussion about adding tables I will leave up to you to move or ignore etc.