FAI-CIVL / FAI-Airscore

AirScore - online paragliding / hanggliding GAP-based scoring software.
https://airscore.cc/
GNU General Public License v3.0
14 stars 18 forks source link

.env variable "app" not defined #302

Closed JEK58 closed 1 year ago

JEK58 commented 1 year ago

In the .env.example PYTHONPATH is defined as PYTHONPATH=${app}:src but I could not find any place where app is actually defined.

biuti commented 1 year ago

In Dockerfile it is made explicit a default path that is working for a standard installation. In my working build that env line is unchanged

JEK58 commented 1 year ago

Hm, I'm not sure if I understood you correctly. In the Dockerfile ENV PYTHONPATH="${PYTHONPATH}:/app/airscore/core:/app" it is set to the value from .env wich as I mentioned above is constructed from the non existents app variable.

It also gives me an error WARN[0000] The "app" variable is not set. Defaulting to a blank string. when starting the container.

biuti commented 1 year ago

I committed a new env example file that avoids warning during launch. That should not change anything, as there are alternatives separated by colon in Dockerfile. It is a test variable I could remove as well. Please have a try

JEK58 commented 1 year ago

Looks good to me