3rdparty - spdlog unnecessarily forced into user code

FAIRDataPipeline / cppDataPipeline

C++ Implementation of the FAIR Data Pipeline API

http://www.fairdatapipeline.org/cppDataPipeline

Other

0 stars 2 forks source link

3rdparty - spdlog unnecessarily forced into user code #19

Closed dezed-ukaea closed 2 years ago

dezed-ukaea commented 2 years ago

fdp.hxx includes spdlog header. spdlog entities required for Datapieline construction.

Loggging level provision specified via spdlog cannot be changed. Ever.

Suggets log level to be specified by a enum FairDataPipeline:log_level{ info, debug, warn ..... } etc

dezed-ukaea commented 2 years ago

Why expose logging interfaces to the user anyway? If they want to log something they can get their own logging API. I suggest removing the logging API forc consumption. Log level can still be specified via an environment variable so the public API is no longer polluted with logging classes.

RyanJField commented 2 years ago

This was legacy code and the spdlog can be removed.

RyanJField commented 2 years ago

I see this is fixed by PR #22.

RyanJField commented 2 years ago

Fixed by PR #22 merged 554236b