FAIRDataPipeline / cppDataPipeline

C++ Implementation of the FAIR Data Pipeline API
http://www.fairdatapipeline.org/cppDataPipeline
Other
0 stars 2 forks source link

Datapipeline - log level #20

Closed dezed-ukaea closed 2 years ago

dezed-ukaea commented 2 years ago

DataPipeline dp1(... log_level=debug) DataPipeline dp2(... log_level=info)

dp1 log_level change to that of dp2

Does each instance need its own log level? Or can the global logger make do with one log level the user sets outside of the DataPipeline class eg

fdp->set_log_level( info ) DataPipline dp1 DataPipline dp2

dezed-ukaea commented 2 years ago

I don't see the point in having a logging parameter in the constructor which sets the global log level. I suggest removing it from the constructor.

RyanJField commented 2 years ago

Agreed, there is no need for the logging level to be set in the DataPipeline constructor and can be removed.