search

FAIRDataPipeline / cppDataPipeline

C++ Implementation of the FAIR Data Pipeline API
http://www.fairdatapipeline.org/cppDataPipeline
Other
0 stars 2 forks source link

3rdparty - ghc::filesystem::path forced upon user #21

Closed dezed-ukaea closed 2 years ago

dezed-ukaea commented 2 years ago

DataPipeline link_read & linw_write return ghc::filesystem::path. Is this necessary? User must adopt library. Why not return string?

RyanJField commented 2 years ago

Originally the API was written using C++ 17 standard and used std::filesystem::path, ghc::filesystem::path was added when the version needed to be compatible with C++ 11 to save time on refactoring.

As there are no major time constraints this dependency can be either be removed or only used internally.