Movpe 1 and movpe 2 merging + some solution class

[aalbino2]

Hey @hampusnasstrom if you can still see this email in the ocean that arrived you in the last hour, could you check this for me? Do not be concerned with movpe specific changes, I just need your comments on the init.py file in the root on the ikz_plugin

Thanks!

[aalbino2]

Done! I tried to solve the doubts on what intended_conc and obtained_conc were standing for.

I hope you find it better now! Thanks for comments, I think it improved

Let'S see if we find a point to merge tomorrow. Then, if we need to chnage it further, I will be avail to update the upload of the movpe people anyway

[RoteKekse]

Hey some feedback from me: The quantities temperature time and speed are solution preparation steps. In my classes i had them on top level and kept them there for backwards compatibility but moved them in an extra section.

The term final_concentration is a bit difficult in context where more then one substance is dissolved and it is not clear by context to what this refers.

I think the component quantity is missing other measures of amount besides mass. solvents usually have a volume. sometimes the solution is only describe by relative values, such as volume or mass or molar concentrations.

The term additive is a bit tricky. in principle this is just another solute, but in crystal chemistry it emphazies that this is part of the doping as far as i understand that and not part of crystal it self.

[aalbino2]

Thanks for comments, indeed I think you make good points here and I refined the classes in the following way

• I removed temperature, time, and speed from Solution class
• I changed this final concentration thing, now there is the ComponentConcentration repeated class referencing a system and specifing its concentrantion, the same class is also used within the mixing step.
• You're right about component, indeed elsewhere I had this liquidComponent subclass, that now I added here
• I removed additive, that was a leftover from your classes still.