FAIRmat-NFDI / AreaA-data_modeling_and_schemas

The ELN custom schemas from synthesis experiments
https://fairmat-nfdi.github.io/AreaA-Documentation/
11 stars 6 forks source link

Descriptions for quantities and sub-sections in transmission plugin #163

Closed ka-sarthak closed 5 months ago

ka-sarthak commented 6 months ago

Below you can find the tree structure of the UVVisTransmission measurement class, TransmissionSpectrophotometer class, and TransmissionSample class. We need concise descriptions for each quantity and sub-section in them.

Some descriptions are already available (these are italicized), but they are mere suggestions. Feel free to suggest better ones.

Ideally, the description should be 1-2 lines long and clear to understand.

UVVisTransmission measurement class

TransmissionSpectrophotometer instrument class

TranmissionSample sample class

ahm531 commented 6 months ago

Hi Sarthak, Here are some descriptions added to the quantities. I am also attaching a page from the help page of the PerkinElmer instrument software from which I got most of the text. Here is the file

UVVisTransmission measurement class

TransmissionSpectrophotometer instrument class

TranmissionSample sample class

ka-sarthak commented 6 months ago

@ahm531 Great work! Thanks a lot for your input and sharing the file from Perkin Elmer.

Some question:

Some remarks:

ka-sarthak commented 6 months ago

@budschi @ahm531 Is there a need to specify the detector materials used in Detector sub-section? In the Perkin Elmer help guide, they write "The instrument uses a single detector (photomultiplier for UV/Vis and PbS or InGaAs for NIR)"

ahm531 commented 6 months ago

Is the polarizer_angle the one for the Accessory.polarizer. If that's the case, then we can move this quantity into the Accessory sub-section. Can you comment on this?

The description for Accessory.polarizer includes "Optional accessory to polarize or depolarize the light beam". This is a bit confusing. Do you mean that two Accessories can be added to either polarize (using a polarizer) or depolarize (using a depolarizer) the light beam? In this case, do you think we should move common_beam_depolarizer to this sub-section?

There is one accessory that can either polarize or depolarize the light. see here

ahm531 commented 6 months ago

@budschi @ahm531 Is there a need to specify the detector materials used in Detector sub-section? In the Perkin Elmer help guide, they write "The instrument uses a single detector (photomultiplier for UV/Vis and PbS or InGaAs for `NIR)"

I think the individual types of detectors are standard. However, for generality, I guess there should be another module in this list module (MEnum(['three detector module', '150-mm integrating sphere']). The three detector module is only available in Lambda 1050. However, the instrument versions have only two detectors (I'm not sure what that mode would be called).

ahm531 commented 6 months ago

Just checked one of my ASC files (Lambda 950) it has the following line (25) about the detector: CommonBeamDepol,RBeamAtt,SBeamAtt,**uv/vis/nir detector**

Do you think we should also include this in the module quantity?

ka-sarthak commented 5 months ago
I guess so. It also confused me at first that they were separated.

@ahm531 Nice, so there's a connection between the two.

I also quote from the manual "The optional depolarizer/polarizer mounts inside the sample chamber. It is used to polarize or depolarize the light beam entering the sample. A switch on the accessory sets it to depolarizer or polarizer".

I don't think the common_beam_depolarizer (CBD) should be moved to this subsection. The CBD is installed inside the spectrometer and works on the common light beam coming from the source (before it is separated into the reference beam and the sample beam in the sample compartment) The polarizer/depolarizer is installed in the sample compartment.

Okay, this is now much clearer to me. CBD is always present and is not an optional accessory per se. The accessory on the other hand allows to both polarize and depolarize the light. In this case, we should have quantities that handle both these options in the accessory.

Just checked one of my ASC files (Lambda 950) it has the following line (25) about the detector: CommonBeamDepol,RBeamAtt,SBeamAtt,**uv/vis/nir detector**

Do you think we should also include this in the module quantity?

The other detector module you mention is the uv/vis/nir detector, right? In the reader, we set three-detector-module when uv/vis/nir detector is found in line 25. Here's the code. Let me know your thoughts on this.

hirokitanaka-ikz commented 5 months ago

@ka-sarthak @ahm531 Hi, concerning the polarizers and depolarizers, I know that some devices have a depolarizer inside, so-called common beam depolarizer (we can activate and deactivate it). Perkin Elmer offers two options: common beam depolarizer or polarizer/depolarizer drive accessory (https://resources.perkinelmer.com/lab-solutions/resources/docs/prd-006991A-04-LAMBDA650-1050PolarizerDepolarizerOptions.pdf). Our Lambda1050 does not have it but the polarizer/depolarizer drive accessory instead.

ahm531 commented 5 months ago

@ka-sarthak Both Lambda 950 and 1050 measure the same range (175-3300 nm) covering UV/Vis/NIR light.

Now, translating uv/vis/nir detector to three-detector module doesn't seem accurate, especially since the Lambda 950 doesn't have three detectors. The term "three-detector module" is specific to the configuration of the Lambda 1050. However, I don't have solution to this at the moment, but would be happy to discuss and compare the asc files from both instruments.

Also, having the three-detector module would mean that there are two wavelength change points when someone is measuring from 175 nm to 3300 nm. I'm wondering if this is accounted for in the code (or planned).

image

ka-sarthak commented 5 months ago

@ahm531 @hirokitanaka-ikz Thank you both for sharing detailed differences in detector between the two instruments. We should make the schema adaptable to the two versions for instrument.

Here are some points from my side:

ka-sarthak commented 5 months ago

Thanks for making this discussion lively! Let's find some time this week to finalize on these points.