search

FAIRmat-NFDI / AreaA-data_modeling_and_schemas

The ELN custom schemas from synthesis experiments
https://fairmat-nfdi.github.io/AreaA-Documentation/
10 stars 6 forks source link

PureSubstance #69

Closed aalbino2 closed 5 months ago

aalbino2 commented 9 months ago

Hi, I just started using the full structure @hampusnasstrom designed, I'm wondering if in The PureSubstance it is correct that the elemental_composition is in the parent section and not in PureSubstanceSection, where the conceptual description of the substance is

Let's discuss this!

I know that it is there due to inheritance from system, it is not super well fitting here though

Screenshot from 2023-10-06 11-26-19

hampusnasstrom commented 9 months ago

I see your point but if it's up to me I would still keep it this way. I think the elemental composition will rarely be filled/viewed manually in the ELN but rather calculated from formulae and components and then used for searches. What do you think @budschi?

budschi commented 9 months ago

I see your point but if it's up to me I would still keep it this way. I think the elemental composition will rarely be filled/viewed manually in the ELN but rather calculated from formulae and components and then used for searches. What do you think @budschi?

My experience is also like @hampusnasstrom described, elemental_composition gets populated automatically without user input. Where would you put exactly @aalbino2 ? It serves the findabilty in searches nicely,