search

FAIRmat-NFDI / AreaA-data_modeling_and_schemas

The ELN custom schemas from synthesis experiments
https://fairmat-nfdi.github.io/AreaA-Documentation/
11 stars 6 forks source link

Indexing the method of Activity #7

Open aalbino2 opened 1 year ago

aalbino2 commented 1 year ago

For the next step of "refactoring eln base classes" activity we are doing

There are several quantities contained in this class:

Activity_category
Activity_method
Activity_location
Experiment_goal

Regardless of where to place them exactly (e.g. as a quantity of Activity or as a quantity of sub_section Global), I was wondering if it can be useful to make the category and method indexed in elasticsearch.

It is a very general filter to look for methods, in view of the growing number of experiments sharing the same method-agnostic base classes. I imagine that some search of specific quantities is intended to be for quantities connected to specific methods.

@hampusnasstrom @Pepe-Marquez

Pepe-Marquez commented 1 year ago

In the quantity method of the base class ElnActivityBaseSection, writes to results.eln.method which is searchable. My advice would be to have the value of method set as default in the custom schemas to keep consistency. It is possible to also look for Custom Quantities now, but doing that way it will be indexed properly in Elastic search making it fast. Let me know if you need any example schemas to see this.

image

https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/blob/develop/nomad/datamodel/metainfo/eln/__init__.py

aalbino2 commented 1 year ago

Ok, good. I will wait for Hampus to merge his work on base_classes where, if I remember correctly, ElnActivityBaseSection will be called Activity.

Thanks