FAIRmat-NFDI / AreaC-DOC

Repository containing the Area C specific documentation for using NOMAD for computational data.
https://fairmat-nfdi.github.io/AreaC-DOC/
Apache License 2.0
2 stars 0 forks source link

Fix broken link #14

Closed ndaelman-hu closed 9 months ago

ndaelman-hu commented 9 months ago

Fix the missing image paths under Upload and Publish.

JosePizarro3 commented 9 months ago

Nice, do you mind fixing the img src in each of the md documents in uploading_and_publishing/?

ndaelman-hu commented 9 months ago

Nice, do you mind fixing the img src in each of the md documents in uploading_and_publishing/?

Can do that, but they should already be rendering, right? It seems that mkdocs fixes the root once overview.md is fine.

JosePizarro3 commented 9 months ago

Really? Ok, let's see. We merge, and if the links are still broken, I will fix it directly to the main.

ndaelman-hu commented 9 months ago

You can check locally too, but

Really? Ok, let's see. We merge, and if the links are still broken, I will fix it directly to the main.

You can check it locally, but for me it works at least. If it doesn't, we just re-open the issue.

JosePizarro3 commented 9 months ago

It seems it didn't fix it, at least now I can see the image in the overview page, but not in the others.

Problem is that locally when doing mkdocs serve is doing something different as when deploying in the gh-pages, but I didn't find any information about this. Don't worry, I will push the new path to the main directly, no need to reopen this.