FAIRmat-NFDI / cookiecutter-nomad-plugin

MIT License
1 stars 1 forks source link

Check for rsync in `move_template_files.sh` #31

Closed Bernadette-Mohr closed 4 weeks ago

Bernadette-Mohr commented 1 month ago

The move_template_files.sh script expects rsync to be installed. When that is not the case, the call fails, but the script as is does not exit. So nothing is copied, and everything is still deleted. I'd suggest changing move_template_files.sh to (POSIX compatible):

#!/bin/sh

if ! command -v rsync >/dev/null 2>&1; then
    echo "rsync required, but not installed!"
    exit 1
else
    rsync -avh nomad-parser-<code>/ .
    rm -rfv nomad-parser-<code>
fi
blueraft commented 4 weeks ago

Thank you!