Support appdef inheritance in dataconverter - Githubissues

FAIRmat-NFDI / data-modeling

3 stars 1 forks source link

Support appdef inheritance in dataconverter #112

Open domna opened 1 year ago

domna commented 1 year ago

There is an issue https://github.com/nomad-coe/nomad-parser-nexus/issues/35

and PR, which contains a test failing on not supported inheritance https://github.com/nomad-coe/nomad-parser-nexus/pull/36

sanbrock commented 1 year ago

also note that dataconverter cuold/should write some more attributes (see NXroot and NXentry):

/@NX_class = "NXroot"
/@file_time
/@file_name
/@HDF5_Version
/@h5py_version
/@creator
/@creator_version
/ENTRY/definition@version (!)
/ENTRY/definition@URL

Note the use of non-standard definitions (expressed in NXDL) as supported by NeXus preferably under /ENTRY/SUBENTRY/ following definitions as referenced in /ENTRY/SUBENTRY/definition_local (https://manual.nexusformat.org/classes/base_classes/NXsubentry.html#nxsubentry-definition-local-field)