domna
commented
1 year ago Follow up issues:
- [x] Fix all containers to pass CI/CD
- [ ] Enable basic nbmake testing for at least on example file per container
- [ ] Check feasibility of a more complex testing scenario
- [x] Set an expiration policy (remove older containers if they do not fit in a regex) - Talk to Adam or Markus to change the settings
- [x] Set the latest tag to the latest tagged version?
- [x] Use only versioned containers in tools.json
- [x] Check webtop baseimage. The choice seems a bit strange (ubuntu-baseimage) to me and maybe should be changed to the versions documented at linuxserver.
- [ ] Use a requirements.in file for python based builds and generate a requirements.txt inside the container to fix the dependencies. There is an example script for generating it with pip-tools in the ellipsometry example.
- [x] Currently, due to the matrix build I'm using it is not possible to start a test depending on a successful build. We would need a DAG based build for that, which is not compatible with matrix based builds, yet: https://gitlab.com/gitlab-org/gitlab/-/issues/254821. Therefore, all containers need to be build successfully to run the test.
General future considerations:
There will be the option to use a custom tools.json in NOMAD soon: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1117
Therefore, it is possible to disconnect this repository from NOMAD as a submodule and only provide an example tools.json there.
Interaction with NOMAD with this repository would then only be via the container registry.
Should be building on #126